[Mono-dev] Mono 1.1.9.1 Windows Installer Released

[Kornél Pál]

Hi Wade,

>I agree with not needing to set the env vars for the bat files.  What
> about the SET/END LOCAL?

setlocal and endlocal makes NT cmd.exe use local scope for environment
variables that means that if you set them after setlocal they won't be
exported outside the batch file. endlocal changes back to global scope. If
we don't set any variables they are useless.

> I'm not sure what you're suggesting for this bug though:
>
> http://bugzilla.ximian.com/show_bug.cgi?id=54677

This is a problem, but as I see the ultimate solution could be to use .exe
wrappers instead of .bat files. But it can be solved with having both .bat
files and shell scripts like we do now.

My opinion about this bug and EXIT:
> Using EXIT is not a good idea as when you call .bat files from other .bat
> files all of them will exit resulting in similar behaviour as you use no
> call command. When you call .bat files from .bat files using call they
> will
> preserve ERRORLEVEL.
> There are shell scripts as well I think they should be used in cygwin.

So this is a problem but if we use EXIT we cannot use .bat wrappers from
other .bat files. That is something bad as native "shell scripts" are .bat
files on NT. But we have shell scripts for cygwin in that directory. People
should use them from cygwin and they will get error code. Note that exit
code is passed between .bat files so it isn't a problem for .bat files.

I suggest this batch file layout:
> @"C:\Program Files\Mono-1.1.9.1\bin\mono.exe" "C:\Program
> Files\Mono-1.1.9.1\lib\mono\1.0\mcs.exe" %*
>
> Without new line at the end as it results in a prompt being displayed.
> Otherwise @echo off should be used.

Shell scripts are OK, so they should not be changed.

>> BTW is there any reason why you decided not to include gdiplus.dll?
>>
>
> I'm still waiting for Miguel to approve it.  He wasn't sure if we should
> or not.

This is for you and if Miguel is unsure please show it for him:

We definitely need it as most of System.Drawing code is a wrapper around
GDI+ so gdiplus.dll dependency is not a question. Windows 2000 has no GDI+
while we need it. In addition gdiplus.dll is a redistributable component
that thas to be installed to the bin directory of the application rather
than to system32 directory. As a conclusion if we don't install gdiplus.dll
on Windows 2000 users will have to violate some license by copying
gdiplus.dll from another software (from MS.NET bin directory for example) to
Mono directory. On the other side we are allowed to redistribute it. And
it's important not to install GDI+ on system later than Windows 2000.

This is my complete guide on integrating GDI+ to Mono Setup:
http://lists.ximian.com/pipermail/mono-devel-list/2005-September/014803.html

If Miguel will still be unsure please show thim the above link as well.

Kornél

----- Original Message -----
From: "Wade Berrier" <wberrier at novell.com>
To: <miguel at novell.com>; "Kornél Pál" <kornelpal at hotmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Saturday, October 01, 2005 12:42 AM
Subject: Re: [Mono-dev] Mono 1.1.9.1 Windows Installer Released


> Hey,
>
> On Fri, 2005-09-30 at 12:52 +0200, Kornél Pál wrote:
>> Hi,
>>
>> AppID is {found} that will result in
>> HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{found}_is1
>> that seems to be bug in the script.
>
> Thanks, this has been corrected.
>
>>
>> BTW is there any reason why you decided not to include gdiplus.dll?
>>
>
> I'm still waiting for Miguel to approve it.  He wasn't sure if we should
> or not.
>
> Wade
>
>
>
>> Kornél
>>
>> ----- Original Message -----
>> From: "Wade Berrier" <wberrier at novell.com>
>> To: <mono-list at lists.ximian.com>; <mono-devel-list at lists.ximian.com>
>> Cc: "Francisco Martinez" <martinf at mfconsulting.com>
>> Sent: Friday, September 30, 2005 12:37 PM
>> Subject: [Mono-dev] Mono 1.1.9.1 Windows Installer Released
>>
>>
>> > Get 'em while it's hot:
>> >
>> > http://www.go-mono.com/archive/1.1.9.1_1/windows/mono-1.1.9.1-gtksharp-1.0.10-2.3.91-win32-0.exe
>> >
>> > Thanks for the suggestions and input.  There are improvements to be
>> > made, but this should do for now.  Let me know of any installer issues.
>> >
>> > Thanks Paco, you rock :)
>> >
>> >
>> > Wade
>> >
>> > _______________________________________________
>> > Mono-devel-list mailing list
>> > Mono-devel-list at lists.ximian.com
>> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>
>