[Mono-dev] Re: External entity resolution

[Atsushi Eno]

Hi Kosta,

I think the idea that entity declaration does not have to resolve
the actual entity until it is referenced is nice to do.
But the patch breaks several tests with NullReferenceException.
Can you please run "make run-test" in System.XML and hopefully
in System.XML/Test/System.Xml/standalone_tests? Andrew made a
pretty useful NUnit integration there.

Thanks,
Atsushi Eno

Konstantin Triger wrote:
> Hello Eno,
> 
>  
> 
> We fail to load the following xml:
> 
>  
> 
> <!DOCTYPE doc [
> 
> <!ENTITY e PUBLIC ";!*#@$_%" "100.xml">
> 
> <!ELEMENT doc (#PCDATA)>
> 
> ]>
> 
> <doc></doc>
> 
>  
> 
> The reason is that we try to set the entity content when it's declared
> and not when it's referenced.
> 
> The attached patch fixes the issue.
> 
>  
> 
> BTW, do we need to resolve it before it's referenced? I guess no... So
> the LiteralEntityValue should be empty and we need to create a XmlReader
> based on SystemId and read the data when requested...
> 
>  
> 
> Regards,
> 
> Konstantin Triger
> 
>  
> 
>