[Mono-dev] another corcompare patch to hide extraneous "IsVirtual" differences

Atsushi Eno atsushi at ximian.com
Tue Nov 1 05:07:59 EST 2005


Hi,

As implemented in the previous patch, corcompare now shows
abstract/virtual/static differnces on methods (including property
accessors).

Now it uncovered the difference on how we implement interface
methods on each class. Say, there is only one Clear in our
System.CodeDom.NamespaceImportCollection.Clear(), while MS.NET
has two Clear() (one is an implicit implementation).

One another case, there are some internal interfaces that
commonize some members (for example, ConfigXmlDocument that implements
IConfigXmlNode, in System.Configuration, has different IsVirtual
attribute on Filename property).

Those differeces come from the fact that a MethodBase.IsVirtual is
True for such a method that is part of an interface implementation.

They are not significant differences that we should care.

Thus, the only differences we should care is whether they are
overridable or not. It prints "should (not) Overridable" instead of
"should (not) be Virtual".

Based on the premise above, I created another corcompare patch.
This time it won't show such annoying differences.

Does it sound fine?

Atsushi Eno
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: virtual-to-overridable.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20051101/a7a12f3f/attachment.pl 


More information about the Mono-devel-list mailing list