[Mono-devel-list] Re: [Mono-patches] r44475 - trunk/mcs/tests

[Martin Baulig]

Hello,

I modified your fix a little bit today since I was getting problems with
a slightly modified version of that test.

If you call ResolveUnreachable() on three statements in a row, flow
analysis is still turned on for each of these statements, but it doesn't
remember any state between them.  This means if you assign a variable in
the 2nd statement and try to access it in the 3rd, this'll fail.

Martin

On Fri, 2005-05-13 at 12:13 +0530, Raja R Harinath wrote:

> "Martin Baulig" <martin at mono-cvs.ximian.com> writes:
> 
> > Author: martin
> > Date: 2005-05-12 17:55:07 -0400 (Thu, 12 May 2005)
> > New Revision: 44475
> >
> > Modified:
> >    trunk/mcs/tests/test-360.cs
> > Log:
> > Fix this.
> >
> >
> > Modified: trunk/mcs/tests/test-360.cs
> > ===================================================================
> > --- trunk/mcs/tests/test-360.cs	2005-05-12 21:54:24 UTC (rev 44474)
> > +++ trunk/mcs/tests/test-360.cs	2005-05-12 21:55:07 UTC (rev 44475)
> > @@ -9,8 +9,8 @@
> >  		}
> >  		else
> >  		{
> > -			string thisDoesnt = "not so";
> > -			System.Console.WriteLine(thisDoesnt);
> > +			// string thisDoesnt = "not so";
> > +			// System.Console.WriteLine(thisDoesnt);
> >  		}
> >  	}
> >  }
> 
> This is wrong.  The testcase is valid, and shows the regression
> introduced by your recent 'unreachable' changes.  I'm trying out an
> alternate patch that should address the bug you fixed.
> 
> - Hari
>