Spam: [Mono-devel-list] xslttest.cs
Atsushi Eno
atsushi at ximian.com
Tue May 10 11:19:34 EDT 2005
Hi Andrew,
> - static readonly ArrayList skipTargets;
> + static readonly ArrayList skipTargets = new ArrayList (new string
[] { });
> + static readonly ArrayList knownFailures = new ArrayList (new string
[] { });
...
> - static XsltTest ()
> - {
> - skipTargets = new ArrayList (new string [] {
> - });
> - }
Originally this .cctor() held not-runnable targets like
skipTargets = new ArrayList (new string [] {
foo,
bar,
baz
});
So I think preserving this form will look better. (It is still
possible to have different list files outer than xslttest.cs.)
> - XmlValidatingReader stylexvr = new XmlValidatingReader (stylextr);
> + new XmlValidatingReader (stylextr);
It won't be needed. Let's just remove it.
Other than them, in general, don't change code format from our
recommended style (method body open brace). There are some
coding guidelines in mcs/class/README ;-)
After fixing them please go ahead and I'll post followups if needed.
Thanks,
Atsushi Eno
More information about the Mono-devel-list
mailing list