[Mono-devel-list] mcs patch for precise location handling

Atsushi Eno atsushi at ximian.com
Tue Jun 28 13:05:48 EDT 2005


Sorry, the last patch actually didn't include the fix for bug
#57047. This time it should be included (I found it running diff
against two diff files).
This time the patch changes only a few things than before:

> You could remove loc from MemberCore and add only property as
> Location Location {     get {
>         return member_name.Location;
>     }
> }

Oh, true. I just replaced the field with the above property.

> It can save a lot.

Actually it was 77618 KB to 77570 KB ;) But yeah, still better.

> Also code like this
> -            ModFlags = Modifiers.Check (allowed_mod, mod, def_mod, loc);
> +            ModFlags = Modifiers.Check (allowed_mod, mod, def_mod, 
> name.Location);
> then could be written more elegant with Location only.

Ok, I changed as long as I noticed.

Additionally I reviewed MemberName.ctor() invocation and added
Location wherever possible (actually only in iterator AFAIR).

Atsushi Eno

More information about the Mono-devel-list mailing list