[Fwd: [Mono-devel-list] Re: System.Xml patch]

[Andrew Skiba]

Hello Eno.

Can you please look and give your opinion on this patch?

Andrew.

-------- Original Message --------
Subject: [Mono-devel-list] Re: System.Xml patch
Date: Wed, 22 Jun 2005 12:48:06 +0300
From: Andrew Skiba <andrews at mainsoft.com>
To: Atsushi Eno <atsushi at ximian.com>
CC: mono-devel mailing list <mono-devel-list at lists.ximian.com>
References: <42B01B72.1050600 at mainsoft.com> <42B04335.9090207 at ximian.com>

Atsushi Eno wrote:
> Hi Andrew,
> 
> Good catch :-) However the fix does not look correct. Your patch
> also avoids entity content evaluation, that means it sometimes
> results in incorrect well-formedness.

Good catch, too ;-)

How about this patch? To save iterations, I made the same check in
ResolveExternalEntityReplacementText, please tell me, if it's unnecessary.

Cheers,
Andrew Skiba.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: valid-sa-086.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050627/90f8c77b/attachment.pl