[Mono-devel-list] [PATCH] Reworked unified Locale classes

Ben Maurer bmaurer at ximian.com
Thu Jun 23 12:36:05 EDT 2005


On Thu, 2005-06-23 at 12:16 -0400, Miguel de Icaza wrote:
> Hello,
> 
> > > Also, to apply this kind of patch that will affect everything, I would
> > > like to know in advance the memory footprint (running mono --profile
> > > before/after should tell us this) and how much extra code is JITed at
> > > startup (how much slower this becomes for a sample program).
> > 
> > I agree with Ben that string are localized only several time and the little
> > performance overhead caused by localization can be ignored. (The overhead
> > should be little.)
> 
> Yes, but Ben limited himself to speculation.

[benm at omega corlib]$ find -name \*.cs | xargs grep Locale.GetText | wc -l
712
[benm at omega corlib]$ find -name \*.cs | xargs grep Locale.GetText | grep -v Exception | wc -l
194

Most of those 194 seem to be cases where Locale was put on a different
line than the throw statement for cosmetic reasons.

> I want to know the real impact (we have the tools, it should take a few
> minutes at most to find out the numbers).

The best way for Kornel to do that (just as an FYI since he has probably
never used the tools) is to run:

mono --stats foo.exe
mono --profile foo.exe

where `foo.exe' is a program that exercises the Locale code, but doesn't
do much else, and send the output for each before and after the change.

-- Ben




More information about the Mono-devel-list mailing list