[Mono-devel-list] [PATCH] Additional System.Collections.Generic.{Dictionary, EqualityComparer} fixes + tests

David Waite dwaite at gmail.com
Sat Jun 18 02:49:29 EDT 2005


2005-06-16  David Waite  <mass at akuma.org>

    * Dictionary.cs (EnumerationMode): Remove.
    (Enumerator): Remove return type flag - legacy return is expected to
    always return a DictionaryEntry
    (Enumerator): Make constructor internal, it is not public on ms.net 
    beta 2
    (Enumerator.MoveNext): Fix endless loop
    (VerifyState): Added method to check state preconditions and throw
    appropriate exceptions.
    (KeyCollection,ValueCollection): Mark sealed to match ms.net beta 2
    (KeyCollection.Enumerator._hostEnumerator): make exact struct type,
    rather than boxing and using by interface
    (KeyCollection.Enumerator.Dispose): use default to clear Enumerator
    (ValueCollection.Enumerator._hostEnumerator): make exact struct type,
    rather than boxing and using by interface
    (ValueCollection.Enumerator.Dispose): use default to clear Enumerator
    * EqualityComparer.cs (DefaultComparer, IEquatableOfTEqualityComparer):
    Mark as serializable.

2005-06-18  David Waite  <mass at akuma.org>

    * DictionaryTest.cs (AddTest3): Added test of simple interaction with
    struct dictionary
    (AddDuplicateTest,IndexerGetNullTest,IndexerSetNullTest): Added tests
    for exceptional cases to verify correct exceptions
    (TryGetValueTest): check return value from TryGetValue
    (KeyValueEnumeratorTest): Added test from verification of ms.net beta2
    behavior for non-generic IEnumerator/IDictionaryEnumerator behavior
    against Dictionary<>
    (SerializationTest): Added test to utilize serialization routines.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Dictionary-changes2.diff
Type: application/octet-stream
Size: 16148 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050618/7d39e14b/attachment.obj 


More information about the Mono-devel-list mailing list