[Mono-devel-list] Re: valid-sa-100 testcase

Eyal Alaluf eyala at mainsoft.com
Fri Jun 17 11:20:32 EDT 2005

Hi, Atsushi.

Just to set things straight. The patch was rejected since it was incomplete
caused regressions and you didn't like the approach. The lack of concrete
test case at the time that motivated the patch prevented us from continuing
the discussion at that time. Now that the lost test was found :-) we are
continuing the discussion.
Now back to the test, how do you propose to fix the issue? What is your
analysis of the issue?
Regarding XmlDocument use, how do you think we should test it? When you changed
xmltest.cs did you have cases where XmlDocument didn't work in Mono but worked
in MS?


On Fri, 17 Jun 2005, Atsushi Eno wrote:

> Date: Fri, 17 Jun 2005 21:30:47 +0900
> From: Atsushi Eno <atsushi at ximian.com>
> To: Andrew Skiba <andrews at mainsoft.com>
> Cc: mono-devel mailing list <mono-devel-list at lists.ximian.com>
> Subject: [Mono-devel-list] Re: valid-sa-100 testcase
> Hi Andrew,
> *regarding subj*, I think we should not mix different things:
> 	- Wellformedness in XmlTextReader
> 	- Validity in XmlValidatingReader
> 	- How XmlEntity/XmlEntityReference behaves
> Since the standalone test should basically target validity in
> XmlReader, the way that patch takes is basically wrong.
> (BTW that's why I fixed xmltest.cs in my XML standalone_tests
> not to use XmlDocument for testing them, once upon a time.)
> Besides the subj, I don't think I have rejected Kosta's patch
> just because there is no testcase. I even sent Kosta and Eyal
> an example case that the patch makes things inconsistent.
> Here I attach it so that anyone can try.
> Atsushi Eno
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xtrsupportsentity.cs
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050617/e320e35e/attachment.pl 
-------------- next part --------------
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com

More information about the Mono-devel-list mailing list