[Mono-devel-list] Re: [Mono-patches] r45986 - in trunk/mcs: build build/common ...

[Raja R Harinath]

Hi,

"Ben Maurer <benm at mono-cvs.ximian.com>" <benm at mono-cvs.ximian.com> writes:

> Author: benm
> Date: 2005-06-14 14:30:41 -0400 (Tue, 14 Jun 2005)
> New Revision: 45986
>
> Added:
>    trunk/mcs/build/common/
>    trunk/mcs/build/common/Locale.cs
> Removed:
>    trunk/mcs/class/Commons.Xml.Relaxng/Assembly/Locale.cs
>    trunk/mcs/class/Cscompmgd/Assembly/Locale.cs
>    trunk/mcs/class/Custommarshalers/Assembly/Locale.cs

I like this change except for two things:

  * the 'build' directory is not an intuitively obvious location for
    common source files.  Move it either to the topdir or to class/.

  * no one's responsible for distributing the files in common/.  It's
    working by accident due to the way executable.make is currently
    written.  I'll be checking in a fix soon.

- Hari