[Mono-devel-list] [PATCH] Reworked unified Locale classes

Ben Maurer bmaurer at ximian.com
Tue Jun 14 20:50:14 EDT 2005


On Mon, 2005-06-13 at 13:14 +0200, Kornél Pál wrote:
> >> What about a pacth that adds a common Locale.cs copy, modifies sources
> >> files
> >> and removes unused Locale.cs files?
> > ...
> > That's exactly what I suggested :-). I think that is the first step.
> 
> This patch has to be easy to review.
> I added the common Locale.cs and I modified the .sources files in all of the
> assemblies except in corlib because it has to have it's own modified
> version.
> I did not remove any files yet so the diff file is much short.
> 
> By the way does corlib have any conditional compilation constants (for
> example INSIDE_CORLIB) defined everytime it is compiled? If it has the same
> Locale.cs could be used with conditional compilation that could make code
> maintenance easier.

INSIDE_CORLIB is defined :-). You could always look at the commands make
runs...

> Please review this patch and approve it if you think so. Otherwise please
> explain me what should I modify.

I committed something similar to this.

-- Ben




More information about the Mono-devel-list mailing list