[Mono-devel-list] build breakage and comments

Konstantin Triger kostat at mainsoft.com
Tue Jun 14 09:28:16 EDT 2005

Hi Suresh,

1. The latest fix in Test/System.Data/DataSetTest.cs broke the tests 
build. Please repair ASAP or revert.
2. The new "internal DataRow Find (object [] keys, DataViewRowState 
rowStateFilter)" in datarowcollection.cs, uses Table.FindIndex and if 
not found creates a new index. So if there is no suitable index a new 
one will be created on each call, what is very inneficient. The better 
practice would be calling table.GetIndex. In addition, the "public 
DataRow Find (object[] keys)" may simply forward to the new more generic 

What do you think?

Konstantin Triger

More information about the Mono-devel-list mailing list