[Mono-devel-list] [PATCH] Reworked unified Locale classes

Ben Maurer bmaurer at ximian.com
Sat Jun 11 14:49:42 EDT 2005

On Sat, 2005-06-11 at 19:54 +0200, Kornél Pál wrote:
> > As I mentioned to you on private email, there is a very big point to
> > doing this. By removing the duplicated code today, your patches tomorrow
> > will be easier for us to read.
> >
> > I'm not suggesting that the Locale.cs today should be what we use
> > forever. I am suggesting: lets first get one Locale.cs which is the same
> > as we have today, and *then* start patching.
> What about a pacth that adds a common Locale.cs copy, modifies sources files
> and removes unused Locale.cs files?
> Not that the single Locale.cs cannot be the same as we have today because we
> have 7 versions today. In fact there are 3 functionally different versions
> only.
> All of them contains "static string GetText (string)" but corlib has "static
> string GetText (string, params object [])" and MWF has "static object
> GetResource(string)".
> So I have to create a modified version from corlib's Locale.cs that has as
> well "static object GetResource(string)".
> Do you think if I post the described patch it can be reviewed easily? If you
> have comments please let me know what should I change.

That's exactly what I suggested :-). I think that is the first step.

-- Ben

More information about the Mono-devel-list mailing list