[Mono-devel-list] patch for bug#57748

[Joshua Tauberer]

Rafael Ferreira wrote:
> This patch fixes bug#57748 by giving the docbrowser its AssemblyInfo
> back and by changing the About dialog to display the extra information.

Hi, Rafael.  You should post monodoc-related patches to mono-docs-list.

> I broke up the About dialog into a 4 tab notebook/treeview
> (about/authors/plugins/version). 

Not bad.

AboutDialog.cs:
>         string[] plugins = {"ECMA Documentation","Mono XML Documentation", "Mono Handbook", "Manual Pages",  "Compiler Errors","ECMA C# Specification" };

The providers are all compiled into monodoc 'statically', so the user 
has no control over it.  I don't think we need to list them.

AssemblyInfo.cs.in:
> [assembly:AssemblyVersion("@DOCBROWSER_VERSION@")]
> [assembly:AssemblyDelaySign(true)]

Nice.

configure.in:
> +DOCBROWSER_VERSION="1.0"

Miguel needs to chime in with how he would want monodoc to be versioned.

Also, it would be nice to display the monodoc version more prominently, 
instead of just in the list of loaded assemblies.

docbrowser/browser.cs:
> -				RootTree.UncompiledHelpSources.Add(args[i+1]);
> +				//RootTree.UncompiledHelpSources.Add(args[i+1]);

Please don't disable my features. :)

> -class Browser {
> +public class Browser {

Why this?

> +    /*
>  	class About {

You can just delete that class and any Glade stuff it has, if any.

> -class Tab : Notebook {
> +public class Tab : Notebook {

Again, I don't think this was necessary.

Thanks for working on updating the about dialog.  Can you fix the issues 
I noted, add a ChangeLog, and then repost the patch on mono-docs-list?

-- 
- Joshua Tauberer

http://taubz.for.net

** Nothing Unreal Exists **