[Mono-devel-list] System.Web/System.Web.UI - patch (code synchronization between Mono and Mainsoft)
bmaurer at ximian.com
Thu Jun 9 19:47:59 EDT 2005
On Thu, 2005-06-09 at 19:05 -0400, Gonzalo Paniagua Javier wrote:
> On Wed, 2005-06-08 at 14:11 +0300, Ilya Kharmatsky wrote:
> > Please review the patch.
> > BTW, in HtmlTextWriter.cs we changed internal structs (e.g.
> > RenderStyle) to be the classes
> > and not structs - this in order to resolve heavy performance problem
> > in our implementation
> > of initialization of arrays of structs. May be the better idea is to
> > change also original mono
> > code - since in this case we can avoid additional "splitting" of code
> > between standard and
> > J2EE configuration. I think impact of this won't be too high - from
> > perspective of memory
> > consumption and performance.
> RenderAttribute, TagInformation and RenderStyle might be ok as classes.
> As you say, this is no big deal. Feel free to make those classes if
> nothing breaks.
What exactly do you guys do when initing an array of structs that is so
In this case, chances are, performance won't suffer that much. It does
make our GC do more work than it needs to (and it is already pretty
heavy on stuff).
However, there are cases where using arrays of structs will give us a
large benefit in C#. So it would make sense to figure out what is
happening, rather than to shove it under the rug.
More information about the Mono-devel-list