[Mono-devel-list] System.Data.DataSet.ReadXml reimplementation

[Boris Kirzner]

Hello all
We're currently working on reimplementation of DataSet.ReadXml.
The need for this fist raised as a result of xml serialization bugs in 
our System.WebServices testsiute, and supported by the will to provide
more "clean" implementation.

Attached is a diff with current svn version.
The current implementation deals with the task by inspecting some pieces 
of xml while reading it and invoking the corresponding actions (read 
xml, infer schema etc.) if needed. It looks that there is a collection 
of solutions for a lot of private cases (each eliminated by some test) 
threated.
The main idea of new implementation is to loop through the xml reader 
(until we're on the same depth level), collect its attributes and nodes 
into root of xml document, and after _all_ the data is collected - act 
accordingly. The diffgram and schema at first element are threated in 
special manner.

It is still a "work in progress" code, and it has a number of 
regressions : in 
MonoTests.System.Data.DataSetReadXmlTest.TestSimpleDiffXmlAll, 
MonoTests.System.Data.DataSetReadXmlTest.TestSimpleSchemaXmlAll and 
MonoTests.System.Data.DataSetReadXmlTest.SequentialRead2.

What is your opinion about the new implementation?

Once again : this is not a ready patch, so do not apply it on your 
working copy, but on the "standalone" one.

Thanks,
Boris

-- 
Boris Kirzner
Mainsoft Corporation
http://www.mainsoft.com