[Mono-devel-list] Re: [Mono-patches] r47713 - in trunk/mcs/class/Novell.Directory.Ldap: . Novell.Directory.Ldap Novell.Directory.Ldap.Asn1

[Ben Maurer]

On Tue, 2005-07-26 at 13:30 -0400, Boris Kirzner  wrote:
> Author: borisk
> Date: 2005-07-26 13:30:01 -0400 (Tue, 26 Jul 2005)
> New Revision: 47713
> 
> Modified:
...
> Log:
> Added ifdef for TARGET_JVM.

> Modified: trunk/mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap/AssemblyInfo.cs
> ===================================================================
> --- trunk/mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap/AssemblyInfo.cs	2005-07-26 16:33:04 UTC (rev 47712)
> +++ trunk/mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap/AssemblyInfo.cs	2005-07-26 17:30:01 UTC (rev 47713)
> @@ -48,7 +48,9 @@
>  [assembly: AssemblyCopyright(" (C) 2003 Novell, Inc")]
>  [assembly: AssemblyTrademark("")]
>  [assembly: AssemblyCulture("")]		
> +#if !TARGET_JVM 
>  [assembly: CLSCompliant(true)]
> +#endif
>  
>  //
>  // Version information for an assembly consists of the following four values:
> 
> Modified: trunk/mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap.Asn1/Asn1Boolean.cs
> ===================================================================
> --- trunk/mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap.Asn1/Asn1Boolean.cs	2005-07-26 16:33:04 UTC (rev 47712)
> +++ trunk/mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap.Asn1/Asn1Boolean.cs	2005-07-26 17:30:01 UTC (rev 47713)
> @@ -35,7 +35,9 @@
>  {
>  	
>  	/// <summary> This class encapsulates the ASN.1 BOOLEAN type.</summary>
> +#if !TARGET_JVM 
>  	[CLSCompliantAttribute(true)]
> +#endif
>  	public class Asn1Boolean:Asn1Object
>  	{
>  

First, the CLSCompliant on all of these classes isn't needed, I think.
The assembly level attribute applies to them unless there is a
[CLSCompliantAttribute(false)] to override it.

Second, couldn't this be fixed more easily by having the .net to java
converter thingy handle removing the attribute rather than relying on
people to ifdef it.

-- Ben