[Mono-devel-list] Implementing HttpResponse.OnCookieAdd

Eyal Alaluf eyala at mainsoft.com
Tue Jul 26 13:14:33 EDT 2005


Hi.

The attached patch removes the '#if TARGET_J2EE' in HttpResponse.OnCookieAdd. I belive
that the (naive) implementation is not TARGET_J2EE specific and is correct for mono as well.
Please review.

Eyal.
-------------- next part --------------
Index: System.Web/ChangeLog

===================================================================

--- System.Web/ChangeLog	(revision 47712)

+++ System.Web/ChangeLog	(working copy)

@@ -1,4 +1,7 @@

 2005-07-26  Eyal Alalouf  <eyala at mainsoft.com>
+	* HttpResponse.cs: OnCookieAdd should not be TARGET_J2EE specific
+
+2005-07-26  Eyal Alalouf  <eyala at mainsoft.com>
 	* HttpRuntime.cs: Under TARGET_J2EE dispose the cache as well in Dispose.
 
 2005-07-26 Gonzalo Paniagua Javier <gonzalo at ximian.com>
Index: System.Web/HttpResponse.cs

===================================================================

--- System.Web/HttpResponse.cs	(revision 47712)

+++ System.Web/HttpResponse.cs	(working copy)

@@ -1059,9 +1055,7 @@

 		[MonoTODO()]
 		internal void OnCookieAdd (HttpCookie cookie)
 		{
-#if TARGET_J2EE	//naive implementation
 			Request.Cookies.Add(cookie);
-#endif
 		}
 
 		[MonoTODO("Do we need this?")]


More information about the Mono-devel-list mailing list