[Mono-devel-list] gacutil patch

[Raja R Harinath]

Hi,

Jackson Harper <jackson at ximian.com> writes:

> So it turns out I have had this sitting on my computer for two months.
> Could someone (Hari) please review this for me? This patch just makes
> sure that sibling files get copied with the package flag.

My understanding is that the package specific directory is only used to
reference the dlls during an mcs compile.  The are _not_ to be used when
the program is executing -- in particular it should not be listed in
MONO_PATH [1].  For that reason, I don't see a need for either the .mdb
or the .config file being copied to the package directory.  So, this
patch may be unnecessary.

- Hari

[1] And of course MONO_PATH itself shouldn't be used (except by me in
    the mcs build tree ;-)  This patch makes that misuse of MONO_PATH
    more convenient, which suggests that we probably shouldn't be
    applying it.

> Index: driver.cs
> ===================================================================
> --- driver.cs	(revision 47532)
> +++ driver.cs	(working copy)
> @@ -291,6 +291,10 @@
>   				if (Path.DirectorySeparatorChar == '/') {
>  					string pkg_path = "../gac/" + an.Name + "/" + version_token + "/" + asmb_file;
>   					symlink (pkg_path, ref_path);
> +					foreach (string ext in siblings) {
> +						string sibling = String.Concat (pkg_path, ext);
> +						symlink (String.Concat (ref_path, ext), sibling);
> +					}
>  					WriteLine ("Package exported to: {0} -> {1}", ref_path, pkg_path);
>   				} else {
>  					// string link_path = Path.Combine (Path.Combine (link_gacdir, an.Name), version_token);