[Mono-devel-list] [PATCH] Fix "neutral" sorting in DataView

[Marc Haisenko]

On Thursday 21 July 2005 10:26, Marc Haisenko wrote:
> On Wednesday 20 July 2005 18:57, Miguel de Icaza wrote:
> > Hello,
> >
> > > And it would be really gentle if you'll supply a test case for your
> > > fix.
> >
> > NUnit tests cases are best as we can integrate those into the regular
> > builds to avoid having regressions.
> >
> > Miguel
>
> Okay, will do... but I'm out of office until next Wednesday and have more
> urgent things to do today, so I can't resubmit my patch including a NUnit
> test before next Wednesday or Thursday (I never wrote a NUnit test but I
> guess I'll find some examples somewhere).

Oh dear... luckily I now managed to write the stuff today. I've wasted two and 
a half hours just for that silly test ! Would anyone care to explain to me 
why the line
Assert.AreEqual (1, 2, "Foo");
causes mcs to complain "error CS0119: Expression denotes a `method group', 
where a `variable', `value' or `type' was expected" ?

Anyway, attached are the fixed patch and an NUnit test. Hope it's what you 
wanted from me, it fails on an unpatched Mono and passes when my patch is 
applied.

C'ya,
	Marc


-- 
Marc Haisenko
Systemspezialist
Webport IT-Services GmbH
mailto: haisenko at webport.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DataView.cs.NeutralSorting2.patch
Type: text/x-diff
Size: 867 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050721/bc151c89/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DataViewSortingTest.cs
Type: text/x-cssrc
Size: 3605 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050721/bc151c89/attachment-0001.bin