[Mono-devel-list] [PATCH] Fix "neutral" sorting in DataView
haisenko at webport.de
Wed Jul 20 12:25:24 EDT 2005
On Wednesday 20 July 2005 17:57, Boris Kirzner wrote:
> Hello Marc,
> I think your patch is fixing the symptom, not the problem.
> If you want to fix the problem, you probably should change DataView code
> so it always uses Sort property instead of sort private member (except
> the places this can not be done), and change the Sort get : it should
> return String.Empty if useDefaultSort is true and sort otherwise.
Yes, you're right. The code already does use the Sort property in the place
that matters (UpdateIndex), so it'd really be better to change get_Sort to
return String.Empty if useDefaultSort is true. I'll change that and send in
the new patch tomorrow.
> And it would be really gentle if you'll supply a test case for your fix.
Do you really think the work is worth the hassle for such an obvious error ? I
agree that tests that demonstrate the bug are a Good Thing (tm), which is why
I've included one with my patch for the ListChanged event in DataView, but,
ya know... I'm lazy ;-)
Webport IT-Services GmbH
mailto: haisenko at webport.de
More information about the Mono-devel-list