[Mono-devel-list] Re: [Mono-patches] r47151 - in trunk/mono-tools: . docbrowser

[Ben Maurer]

Hey Mario,

Just a few comments. First, whenever you do a commit, you need to write
a change log. The ChangeLog file in any directory has the correct
format. If you use emacs, the easiest way to create a new entry is to do
C-x 4 a.

> +PKG_CHECK_MODULES(GECKO_SHARP, gecko-sharp=0.6)
> +AC_SUBST(GECKO_SHARP_LIBS)
> +

This means that gecko# is *required*. I'm not sure if that's what Miguel
wants.

> Added: trunk/mono-tools/docbrowser/HtmlRender.cs
Each class should probably have its own file. Not only does this make
things easier to fine, it means that you can make gecko conditional
without any #if tags.

I wonder if these classes/interfaces should be public.

> +interface IHtmlRender {
> +	// Jump to an anchor of the form <a name="tttt">
> +	void JumpToAnchor (string anchor_name);
...
> +	//Render the HTML code given
> +	void Render (string HtmlCode);

Your param names aren't consistent. You should use underscore_names
everywhere. (

-- Ben