[Mono-devel-list] [PATCH] Cleanup of MonoClass member usage in metadata

[Ben Maurer]

On Mon, 2005-01-31 at 19:21 +0100, Paolo Molaro wrote:
> The correct way to use the iterators is with a for loop:
> 
> 	for (iter = NULL; (m = mono_class_get_methods (klass, &iter)); ) {
> 		...
> 	}
> or, when using while:
> 	iter = NULL;
> 	while ((m = mono_class_get_methods (klass, &iter))) {
> 		...
> 	}

Ok, I'll recode with the second `while' style.

> > Index: debug-helpers.h
> > ===================================================================
> > --- debug-helpers.h	(revision 39775)
> > +++ debug-helpers.h	(working copy)
> > @@ -38,7 +38,5 @@
> >  
> >  char*           mono_method_full_name (MonoMethod *method, gboolean signature);
> >  
> > -MonoMethod *    mono_find_method_by_name (MonoClass *klass, const char *name, int param_count);
> 
> You can't remove functions from the public interface.

This function was created by:

r35524 | zoltan | 2004-11-01 05:50:23 -0500 (Mon, 01 Nov 2004) | 8 lines
 
2004-11-01  Zoltan Varga  <vargaz at freemail.hu>
 
        * string-icalls.c (ves_icall_System_String_ctor_encoding):
        Implement this. Fixes #67264.
 
        * debug-helpers.h debug-helpers.c marshal.c: Move
        mono_find_method_by_name to debug-helpers.c.

So way, way, way after the 1.0 release.

His patch did:

--- marshal.c   (revision 35523)
+++ marshal.c   (revision 35524)
@@ -52,25 +52,6 @@
 static void
 emit_struct_conv (MonoMethodBuilder *mb, MonoClass *klass, gboolean to_object);
  
-static MonoMethod *
-mono_find_method_by_name (MonoClass *klass, const char *name, int param_count)
-{

So, this was never in the public interface for a major release. I'll
assume that this allows the method removal, if not please speak up.


> Once you make the changes, please post another patch. I'd wait to
> commit it after the release, though, since it's large, it may
> introduce bugs and it's not a bug fix.

I'll send another patch after the release.