[Mono-devel-list] [PATCH] DebuggableAttribute

[Jonathan Pryor]

On Wed, 2005-01-19 at 19:35 -0500, Ben S. Stahlhood wrote:
> I hope I got it right this time K

Not quite.  It doesn't match Mono's coding conventions.

+#if NET_2_0
+               public DebuggableAttribute(DebuggingModes modes) {

The opening brace for methods should be on a new line.

+               public DebuggingModes DebuggingFlags { get { return debuggingModes; } }

Property declarations should be split across multiple lines, e.g.

+               public DebuggingModes DebuggingFlags {
+			get { return debuggingModes; }
+		}

I'm aware that the original file used the single-line layout, but it had
only one property and you're adding two.  Use the standard layout.

+               public enum DebuggingModes 
+               {

The opening brace for classes, structures, and enums should go on the
same line as the type name.

Thanks,
 - Jon