[Mono-devel-list] DebuggableAttribute PATCH Review

Jonathan Pryor jonpryor at vt.edu
Wed Jan 19 07:25:04 EST 2005


To answer your earlier question, yes, mono-devel-list is the correct
place to send patches.

As for this patch, it sadly isn't a patch; it's an entirely new version
of the file.

Can you please resend in `diff -u -P -N' format?  This makes it easier
for us to see what you've actually changed.

Also, please read the code formatting guidelines in:

	http://mono.myrealbox.com/source/trunk/mcs/class/README

In particular, your properties should be similar to:

	public DebuggingModes DebuggingFlags {
		get {return debuggingModes;}
	}

You also don't need all the comments to mark end-of-scope 
(e.g. "// IsJITTrackingEnabled").  This is what good editors are for.

Thanks,
 - Jon





More information about the Mono-devel-list mailing list