[Mono-devel-list] [PATCH] Implementation for ReflectionOnlyLoad methods

Carlos Alberto Cortez calberto.cortez at gmail.com
Wed Jan 19 02:49:18 EST 2005


Hi,

I've just finished the implementation of two of the three
ReflectionOnlyLoad methods (one is still missing, and observe that small
changes could still be needed). Attached are three patches (for
System.Reflection, System, and mono/mono/metadata).

Following Paolo's recomendations, I've kept the compatibility with most
of the public functions, and have only changed the signature of static
ones.

Also, Zoltan commented me about one part of the code in reflection.c:


        }
-       mono_class_init (klass);
+       if (!klass->image->assembly->ref_only)
+               mono_class_init (klass);
        res = (MonoReflectionType *)mono_object_new (domain, 

In this case, Zoltan said to me that mono_class_init() should be called,
even for ReflectionOnly assemblies; however, since all the information
is retrieved by this api using the medatada, initializing vtables and
other stuff (which is being done in mono_class_init) shouldn't be
needed.

I think it is read to be commited (except, of course, by the fact that
any style/code errors the jit guys could tell me).

Carlos.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metadata.patch
Type: text/x-patch
Size: 32503 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050119/a247aa8a/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reflection.patch
Type: text/x-patch
Size: 3165 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050119/a247aa8a/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: system.patch
Type: text/x-patch
Size: 3502 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050119/a247aa8a/attachment-0002.bin 


More information about the Mono-devel-list mailing list