[Mono-devel-list] Path for ReflectionOnly support

[Zoltan Varga]

                                                Hi,

  Most of the code looks ok to me. However, my code review skills are
not very good. Better
wait until Paolo reviews it.

Some comments:

Index: reflection.c
>> ===================================================================
>> --- reflection.c        (revisiA3n: 38513)
>> +++ reflection.c        (copia de trabajo)
>> @@ -5330,7 +5330,8 @@
>>                         return klass->reflection_info;
>>                }
>>        }
>> -       mono_class_init (klass);
>> +       if (!klass->image->assembly->ref_only)
>> +               mono_class_init (klass);

mono_class_init () should be called even in the ref_only case, since
it is needed for the
methods in the Type class to work.

                        Zoltan



On Fri, 07 Jan 2005 18:51:41 -0600, Carlos Alberto Cortez
<calberto.cortez at gmail.com> wrote:
> Hi,
> 
> I've been recently trying to implement the Assembly.ReflectionOnly
> methods, that are part of the whidbey version of .Net. The basically
> load assemblies and retrieving only the medatada, adn throwing an
> exception if some code is invoked.
> 
> Some more info can be found here:
> 
> I'm definitely not yet done with this methods; however, I'm working on
> the ReflectionOnlyLoadFrom method, which should be *simpler* than the
> other two remaining methods.
> 
> I've not finished the support (some checks must be done in some
> System.Reflection classes), but I would like the jit guys to review my
> current advance and also check for possible style/code errors.
> 
> Carlos.
> 
> 
>