[Mono-devel-list] [PATCH] Flags handling for _wapi_recv, _recvfrom, _send, _sendto and getsockopt

[Dick Porter]

On Mon, 2005-02-28 at 19:27 +0530, Ankit Jain wrote:
> Attached patch adds conversion of SocketFlags to linux flags required
> for _wapi_recv, _wapi_recvfrom, _wapi_send, _wapi_sendto calls.

The patch adds non-W32 API to io-layer, which breaks the windows build.
You should turn managed flags into platform-specific values in
metadata/socket-io.c using the standard preprocessor defines, not
hardcoded hex values.

> 
> I'm not sure how to handle these flags though:
> 
> DontRoute
> MaxIOVectorLength
> Partial

If these are managed flags, then they have to be mapped to OS ones if
supported, or throw an exception if not.

> Also, the patch adds handling of SocketOption.Error for getsockopt
> which isn't handled in the existing code.

That part of the patch looks correct.

- Dick