[Mono-devel-list] [Patch] Reflection Only
Zoltan Varga
vargaz at gmail.com
Thu Feb 24 11:36:20 EST 2005
Hi,
Are there any nunit tests for the new methods ? If there are, they should be
checked in too.
Zoltan
On Wed, 23 Feb 2005 02:08:25 -0600, Carlos Alberto Cortez
<calberto.cortez at gmail.com> wrote:
> Hey Zoltan,
>
> I've applied the cahnegs you mentioned in my local tree. Waiting for you
> to review the other changes.
>
> Thanks,
> Carlos.
>
> El mar, 22-02-2005 a las 19:13 +0100, Zoltan Varga escribió:
> > Hi,
> >
> > Some comments:
> > - In GetCustomAttributesData (), it would be better to call
> > Array.AsReadOnly<CustomAttributeData> (attrs) instead of allocating a new
> > list.
> > - In assembly.c:
> > +AssemblyPreLoadHook *assembly_refonly_preload_hook = NULL;
> > this should be static.
> >
> > I will try to review the reflection.c changes later, the others look
> > ok to commit.
> >
> > Zoltan
> >
> > On Wed, 16 Feb 2005 06:52:04 -0600, Carlos Alberto Cortez
> > <calberto.cortez at gmail.com> wrote:
> > > Hi,
> > >
> > > This is the latest patch for implementing the support of ReflectionOnly
> > > methods that are part of the .Net Whidbey, with the last changes
> > > suggested by Paolo. I have also change the names from *_refonly to
> > > *_fullname, by a suggestion of Raja, and which I found much better.
> > >
> > > It also adds support for retrieving CustomAttributeData, which is
> > > basically the attribute data itself.
> > >
> > > Maybe could we commit this?
> > >
> > > Carlos.
> > >
> > >
> > >
>
>
More information about the Mono-devel-list
mailing list