[Mono-devel-list] Re: [Mono-patches] r40971 - trunk/mcs/mcs

[Raja R Harinath]

Hi,

"Marek Safar <marek.safar at seznam.cz>" <marek at mono-cvs.ximian.com> writes:

> Log:
> 2005-02-21  Marek Safar  <marek.safar at seznam.cz>
>
> 	Fix #69949
> 	* attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
> 	argument. Call ResolveAttributeUsage for unresolved.
> 	when types doesn't match ctor arguments.
> 	
> 	* class.cs (DoDefineMembers.TypeContainer): Removed safety check
> 	for nested attribute classes.
> 	(Class.attribute_usage): Removed.
> 	(Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
> 	for attribute class.
> 	
> 	* ecore.cs (IsAttribute): Removed.
> 	
> 	* namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
> 	
> 	* rootcontext.cs (RegisterAttribute): Removed, attributes are
> 	now normal types.
> 	(attribute_types): Removed.
> 	(EmitCode): Global attributes are emited as the latest.
[snip]
> Modified: trunk/mcs/mcs/namespace.cs
> ===================================================================
> --- trunk/mcs/mcs/namespace.cs	2005-02-21 08:05:48 UTC (rev 40970)
> +++ trunk/mcs/mcs/namespace.cs	2005-02-21 08:25:38 UTC (rev 40971)
> @@ -248,9 +248,10 @@
>  					return resolved as Namespace;
>  
>  				DeclSpace root = RootContext.Tree.Types;
> +				NamespaceEntry orig_ns = root.NamespaceEntry;
>  				root.NamespaceEntry = NamespaceEntry;
>  				resolved = Name.ResolveAsTypeStep (root.EmitContext);
> -				root.NamespaceEntry = null;
> +				root.NamespaceEntry = orig_ns;
>  
>  				return resolved as Namespace;
>  			}

I think this is not right.  root.NamespaceEntry should be null, because
it's meaningless except in specific circumstances.

Thanks,
- Hari