[Mono-devel-list] Some patches for Collection

[Ben Maurer]

> On Thu, 2005-02-17 at 07:20 -0500, Ben Maurer wrote:
>
>> We get bugs like this reported every so often. It is pretty clear that
>> there is production code relying on the thing.
>>
>> I don't like it one bit, but I'd rather not get get the bug again.
>
> Hi Ben,
>
> I don't quite follow here :-(
>
> You can't "fix" that because the next time you'd have to revert it again
> to change it back again and then change it again next time and change it
> again ...
>
> The problem is that someone is relying on a broken behavior of Equals().
> Normally, in a non-broken world, if `a' equals `b', then `b' also equals
> 'a' - either `a' and `b' are equal or they're not.
>
> For me, the only logical reason for changing the order of Equals()'s
> arguments is that there is some broken implementation of Equals()
> somewhere where `a.Equals (b)' does not imply `b.Equals (a)'.

It is broken. People rely on it in production code. So we do the trivial fix.

-- Ben