[Mono-devel-list] Some patches for Collection

Martin Baulig martin at ximian.com
Thu Feb 17 06:03:33 EST 2005


On Tue, 2005-02-15 at 01:18 +0900, Kazuki Oikawa wrote:

> Array.diff, SortedList.diff, Stack.diff
> These patches fix the problem of returning wrong result in IndexOf and such method.

Hi,

the patches are all wrong.

One can argue which way around is best, but that's something which is
decided when that method is written the first time.

I clearly will not accept any patch which is just trying to work around
or hide a bug in someone's code.

What you're trying to do with your patches is changing a.Equals (b) to
b.Equals( a) - which means that you have a fundamental design problem in
your code.

Martin





More information about the Mono-devel-list mailing list