[Mono-devel-list] [PATCH] ReflectionOnly methods

[Paolo Molaro]

On 02/01/05 Carlos Alberto Cortez wrote:
> Maybe the only issue is that I'm keeping the hook functions used by
> reflection only api public. I have done that way, since the equivalent
> hook functions for normal assemblies are public too. Should I anyway
> hide them?

I wouldn't expose them as public API.

> By the way: I'll be sending test cases for this methods in the next
> days.

Yes, please also provide the tests you used to check the new
functionality.


> Index: appdomain.c
> ===================================================================
> --- appdomain.c	(revisión: 39945)
> +++ appdomain.c	(copia de trabajo)
> @@ -80,8 +80,10 @@
>  	mono_thread_pool_init ();
>  	mono_marshal_init ();
>  
> -	mono_install_assembly_preload_hook (mono_domain_assembly_preload, NULL);
> -	mono_install_assembly_search_hook (mono_domain_assembly_search, NULL);
> +	mono_install_assembly_preload_hook (mono_domain_assembly_preload, (gpointer) FALSE);

Here and in a few other places you cast an integer to a pointer using (gpointer):
please use GUINT_TO_POINTER(val).

> @@ -829,12 +841,13 @@
>  	MonoDomain *domain = mono_domain_get ();
>  	GSList *tmp;
>  	MonoAssembly *ass;
> +	gboolean refonly = (gboolean) user_data;

Use GPOINTER_TO_UINT ().

>  AssemblySearchHook *assembly_search_hook = NULL;
> +AssemblySearchHook *assembly_refonly_search_hook = NULL;

Use static.

Thanks.

lupus

-- 
-----------------------------------------------------------------
lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better