[Mono-devel-list] XSLT patches reviewed

[Atsushi Eno]

Hi,

So I've largely finished applying the patch. I still have some
pending stuff:

xslnumber.patch
	I need more precise understanding about number formatting
	which is expected in XSLT spec (or please point the related
	spec section number in your patch).

xsforeach.patch
	I need clarification on the purpose of this patch.
	Performance?

xsltcompiledcontext.patch
	I need clarification. What if there are foo-bar and foo_bar?

xslstylesheet.patch
locationpathpattern.patch
	I need clarification on the purpose of these patches.
	With OASIS's stable archive I could not find any improvements.

xmlwriteremitter.patch
	I should reject this patch. It is enough to invoke
	String.Replace() just once (because it replaces all
	the matching string occurence). Also, two WriteComment()
	without object creation is better than allocating another
	string object in general.

parser.patch
	It actually broke the build. We already have ErrorOutput
	maybe for the same purpose.

whitespacenodes.patch
	Let me read the spec in depth. Without related spec section
	it is impossible to determine if the patch is fine (and that
	part is one of the difficult part of XSLT).

For now, am going to make our standalone tests runnable with the
new archive and/or reuse your test runner. I prefer mine only
because there are several options, but in the meantime it is easier
to reuse Class1.cs.

I believe all the rest part of the patch is in svn, but tell me if
there was missing. In general very nice patches :-)

Thanks,
Atsushi Eno
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xslnumber.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xslforeach.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0001.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xslstylesheet.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0002.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: parser.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0003.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xmlwriteremitter.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0004.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: locationpathpattern.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0005.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xsltcompiledcontext.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0006.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: whitespacenodes.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050209/de55245e/attachment-0007.pl