[Mono-dev] [PATCH] Validation for <xsl:output> attributes.

[Gert Driesen]

> -----Original Message-----
> From: mono-devel-list-bounces at lists.ximian.com 
> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf 
> Of Atsushi Eno
> Sent: zondag 25 december 2005 15:39
> To: Gert Driesen
> Cc: mono-devel-list at ximian.com
> Subject: Re: [Mono-dev] [PATCH] Validation for <xsl:output> 
> attributes.
> 
> Gert Driesen wrote:
> >  
> > 
> >> -----Original Message-----
> >> From: mono-devel-list-bounces at lists.ximian.com 
> >> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf 
> >> Of Atsushi Eno
> >> Sent: zondag 25 december 2005 4:44
> >> To: Gert Driesen
> >> Cc: mono-devel-list at ximian.com
> >> Subject: RE: [Mono-dev] [PATCH] Validation for <xsl:output> 
> >> attributes.
> >>
> >>>> It indeed is "indent" part matter. Anyways you don't 
> have to touch
> >>>> the code anymore. I fixed the bug. There is no failing 
> NUnit tests
> >>>> and no more regressions in standalone tests now.
> >>> It also applies to "standalone" and "omit-xml-declaration" 
> >> attributes (see
> >>> the new tests I added to XslTransformTests), and extranous 
> >> attributes.
> >>
> >> Mmm, did you ever mention it when you posted the patch and before 
> >> committing your massive changes which were mostly just 
> >> changing CRLF/LF
> >> and message format changes in SVN?
> > 
> > Nope, I didn't know this then. Did you mention anything 
> about forwards
> > compatiblity back then ?
> 
> Yes:
> 
> >> Can you tell me what failures you get in the Mainsoft XSLT tests ?
> > 
> > 1) output_output05 : Different.
> > 2) BVTs_bvt098 : Different.
> > 3) ForwardComp__91848 : Unexpected exception:

That was after you had approved my changes, but well ... (and no you did not
give approval for changes to Xslt(Compile)Exception, but that has nothing to
do with the forwards compatibility regression).

No need to keep going about this though ...

> > 
> > Especially 3) tells that previous solution was better (did you ever
> > think about forward compatibility?):
> 
> 
> >> You could have just run standalone tests and see what happens.
> > 
> > Yes, but they didn't work. And the tests I added worked 
> fine on both MS.NET
> > 1.x/2.0 and Mono now, but I didn't know about forwards 
> compatibility ...
> 
> It had already been fixed before the last reply.

I know, but after I had committed my changes.

Gert