[Mono-dev] [PATCH] Validation for <xsl:output> attributes.

[Gert Driesen]

> -----Original Message-----
> From: mono-devel-list-bounces at lists.ximian.com 
> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf 
> Of Atsushi Eno
> Sent: zondag 25 december 2005 4:44
> To: Gert Driesen
> Cc: mono-devel-list at ximian.com
> Subject: RE: [Mono-dev] [PATCH] Validation for <xsl:output> 
> attributes.
> 
> > > It indeed is "indent" part matter. Anyways you don't have to touch
> > > the code anymore. I fixed the bug. There is no failing NUnit tests
> > > and no more regressions in standalone tests now.
> > 
> > It also applies to "standalone" and "omit-xml-declaration" 
> attributes (see
> > the new tests I added to XslTransformTests), and extranous 
> attributes.
> 
> Mmm, did you ever mention it when you posted the patch and before 
> committing your massive changes which were mostly just 
> changing CRLF/LF
> and message format changes in SVN?

Nope, I didn't know this then. Did you mention anything about forwards
compatiblity back then ?

> > One more question: apart from lack of support for forwards 
> compatibility
> > (which is not directly related/limited to "indent" 
> attribute), what was
> > buggy about my change for indent attribute ?
> 
> Am too lazy so I just paste it again.
> 
> > > > > >> It is incorrect. It was the first reply I precisely 
> > > > > pointed out that
> > > > > >> HTML output is broken here, and after my reply you 
> > > committed what
> > > > > >> you haven't posted.
> 
> You could have just run standalone tests and see what happens.

Yes, but they didn't work. And the tests I added worked fine on both MS.NET
1.x/2.0 and Mono now, but I didn't know about forwards compatibility ...

Gert