[Mono-dev] [PATCH] Validation for <xsl:output> attributes.

[Gert Driesen]

> -----Original Message-----
> From: Atsushi Eno [mailto:atsushi at ximian.com] 
> Sent: vrijdag 23 december 2005 20:31
> To: Gert Driesen
> Cc: mono-devel-list at ximian.com
> Subject: Re: [Mono-dev] [PATCH] Validation for <xsl:output> 
> attributes.
> 
> Gert Driesen wrote:
> > Comments inline 
> > 
> >> -----Original Message-----
> >> From: mono-devel-list-bounces at lists.ximian.com 
> >> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf 
> >> Of Atsushi Eno
> >> Sent: dinsdag 20 december 2005 6:26
> >> To: Gert Driesen
> >> Cc: mono-devel-list at ximian.com
> >> Subject: Re: [Mono-dev] [PATCH] Validation for <xsl:output> 
> >> attributes.
> >>
> >> Hi,
> >>
> >>> The attached patch implements validation for <xsl:output> 
> >> attributes, and
> >>> adds unit tests.
> >> Thanks!
> >>
> >>> I've also added some unit tests for XsltCompileException 
> >> and XslException.
> >>> Some test are marked NotWorking, due to bugs in Mono (for 
> >> which I'll report
> >>> bug reports later).
> >>>
> >> Some comments:
> >>
> >> 	- You can try Mainsoft XSLT standalone tests. Go to
> >> 	  Test/System.Xml.Xsl/standalone and run "make run-test", then
> >> 	  you can find some regressions.
> >> 	- Your code that checks attributes is good.
> >> 	- "indent" in xsl:output is "yes" by default when the output
> >> 	  method is "html", unlike when it is "xml" ("no"). That's why
> >> 	  we have string value instead of boolean in XslOutput class.
> > 
> > I now use an enum for this internally, which allows us to 
> continue exposing
> > Intend as a bool.
> 
> Please checkin this change as well. Some of Mainsoft XSLT tests
> started to fail after r54780.

Hmm, that change was part of r54780. I tried to run the Mainsoft XSLT tests,
but patching of testsuite/TESTS/catalog-fixed.xml failed for some reason :(

I've just added two more tests for XML/HTML indentation (indent explictly
set to yes/no, and default value) that work fine on both Mono and MS.NET
1.x/2.0.

Can you tell me what failures you get in the Mainsoft XSLT tests ?

Sorry if I my changes caused regressions, but I really added lots of tests
to make sure that they did not :(:(

Gert