[Mono-dev] [PATCH] Validation for <xsl:output> attributes.

Atsushi Eno atsushi at ximian.com
Tue Dec 20 00:25:31 EST 2005


> The attached patch implements validation for <xsl:output> attributes, and
> adds unit tests.


> I've also added some unit tests for XsltCompileException and XslException.
> Some test are marked NotWorking, due to bugs in Mono (for which I'll report
> bug reports later).

Some comments:

	- You can try Mainsoft XSLT standalone tests. Go to
	  Test/System.Xml.Xsl/standalone and run "make run-test", then
	  you can find some regressions.
	- Your code that checks attributes is good.
	- "indent" in xsl:output is "yes" by default when the output
	  method is "html", unlike when it is "xml" ("no"). That's why
	  we have string value instead of boolean in XslOutput class.
	- unindent cases in switches, i.e.

		switch (foo) {
		case bar:

	- The reason why you marked [NotWorking] on
	  XsltExceptionTests.Constructor2() is because

		xsltException = new XsltException ((string) null,cause);

		Assert.AreEqual (string.Empty, xsltException.Message);

	  "fails", right? Hmm, It's still okay to keep this test, but
	  I don't think it is kind of thing we should fix. Having empty
	  message for an exception does not make sense.

	  I guess, most of the reason in NotWorking are like that. If
	  so, you don't have to file bugs for them. Just add some
	  comments in the sources.

Please commit the patch after fixing them.

Atsushi Eno

More information about the Mono-devel-list mailing list