[Mono-dev] [PATCH] Add default code page to build system

[Kornél Pál]

Hi,

Our compiler, mcs uses ISO-28591 as the default code page. This was true in
the past and is true currently as well. (There were problems when we tried
to use Encoding.Default but that is impossible to use we have to use a
specific code page.) This means that the whole class library compiles using
this code page and we seem to use this code page (ISO-28591). The only
exception is Microsoft.VisualBasic. It uses UTF-8 for a long time and it
uses /codepage:650001 in it's Makefile.

My patch does not change code pages. I just want to fix the fact that mcs
cannot use Encoding.Default as it should because we are defining our default
code page (ISO-28591) in the compiler instead of in a configuration file.

Your (Miguel) solution was to revert mcs to use ISO-28591 as the default
instead of Encoding.Default.

My solution is to specify the codepage we want to use to mcs compiler and
modify mcs to use Encoding.Default by default to behave as it's expected and
this is what most people using mcs needs as they edit source code using
their native (system default) code page so they want to compile it using
that code page as well.

This patch is no way related to the default encoding we use as we used
ISO-28591 in the past and we will ISO-28591 after this patch as well. An I
think using a CODEPAGE variable it is easier to modify default code page in
global or Makefile scope as well.

Do you still think that the whole mcs tree has to be revised before
committing this patch? Do you have any other notices regarding this patch?

Kornél

----- Original Message -----
From: "Miguel de Icaza" <miguel at ximian.com>
To: "Kornél Pál" <kornelpal at hotmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Wednesday, August 31, 2005 3:20 AM
Subject: Re: [Mono-dev] [PATCH] Add default code page to build system


> Hello,
>
>> Please review the patch and approve it if it's OK.
>
> First, I would like to do a survey and find what kinds of encodings we
> are using on the file system, and standardize those first.
>
> Miguel
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>