[Mono-dev] [PATCH] Moving MonoVersion to Consts.cs

Raja R Harinath rharinath at novell.com
Wed Aug 24 06:53:33 EDT 2005


>>> On Wed, Aug 24, 2005 at  1:57 pm, in message
<00d301c5a885$bb832ce0$0100a8c0 at kornelpal.hu>, Kornél Pál
<kornelpal at hotmail.com> wrote: 

> Currently a MonoVersion.cs file is generated by configure.in that contains a
> AssemblyVersion attribute. I think it's a better solution to put a
> MonoVersion contstant to Consts.cs and use the constant in the
> AssemblyInfo.cs files of asssemblies. This let us to use the constant itself
> and the source code looks better as there is no extra MonoVersion.cs.
> Using variables in AC_OUTPUT seems to be impossible so I used sed to parse
> Consts.cs.in. I think this is not a big problem as I can hardly imagine that
> we will need other preprocessed constants in Consts.cs.

Looks good to me.

- Hari

More information about the Mono-devel-list mailing list