[Mono-dev] patch to fix CS0642 warning for if-else statement

Raja R Harinath rharinath at novell.com
Wed Aug 24 06:51:06 EDT 2005


Hi Eno,

>>> On Wed, Aug 24, 2005 at  3:12 pm, in message
<430C40FC.6050003 at ximian.com>,
Atsushi Eno <atsushi at ximian.com> wrote: 

> I made a tiny patch for cs0642 warning (attached). It only fixes
> if- else statement cases. Will continue to fix #66777.
> 
> I noticed that the use of EmptyStatement.Value hides the actual
> location to report. Basically using singleton is harmful for
> error reporting. Would it be bad idea if I replace all of them
> and create instance for each empty statements?

I think it's OK, except that we have to ensure that all code that
compares 
against EmptyStatement.Value should test the type instead.

- Hari




More information about the Mono-devel-list mailing list