[Mono-dev] [Patch] AssemblyName ctor

[Andreas Nahr]

There is a case-insensitive ordinal compare in .Net 2.0 that you should use.
If you use InvariantCulture you get a linguistic comparison based on the 
invariant culture.
However these strings don't look like any natural language text that needs 
natural language processing.
It will also construct the whole ICU4C and possibly ICU libraries, which is 
extremely costly.

I really whish MS would have made two string classes in the first place: 
String and LanguageString

Andreas

----- Original Message ----- 
From: "Carlos Alberto Cortez" <calberto.cortez at gmail.com>
To: "Andreas Nahr" <ClassDevelopment at A-SoftTech.com>
Cc: "Mono Devel" <mono-devel-list at lists.ximian.com>
Sent: Saturday, August 20, 2005 12:34 AM
Subject: Re: [Mono-dev] [Patch] AssemblyName ctor


> Hello again,
>
> comments below:
>
>
>> +     if (String.Compare (parts [i], 0, "Version=", 0, 8, true,
>> CultureInfo.InvariantCulture) == 0)
>> This is most likely incorrect and needs to use an ordinal comparison, no
>> InvariantCulture (used more than one time)
>
> I'm not sure that's correct. I tested in .Net and we requiere
> insensitive comparison, not ordinal ones (as far I understood). So I
> think I'll keep it this way.
>
> Carlos.
>
>