[Mono-dev] [PATCH] Default value fixes for WebControl, + UnitConverter infinite loop fix

[Michael Hutchinson]

Some corrected default values for the properties of
System.Web.UI.WebControls.WebControl.
There's also a fix for a potential infinite loop in UnitConverter that
occurs when converting to/from non-string types.

Could someone review this, and if ther are no objections I'll commit it.

On a related note, I am uncomfortable with the constructor for
System.ComponentModel.DefaultValueAttribute.cs

public DefaultValueAttribute (Type type, string value)
{
	try {
		TypeConverter converter = TypeDescriptor.GetConverter (type);
		DefaultValue = converter.ConvertFromString (null,
CultureInfo.InvariantCulture, value);
	} catch { }
}
It should not be swallowing exceptions; if there are any, then the
dveloper has given the DefaultValueAttribute a bad value. However, I'm
reluctant to suggest changing this right now in case it breaks
anything.

Regards,

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DefaultValue.patch
Type: text/x-patch
Size: 3488 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050819/538e4aab/attachment.bin