[Mono-dev] [PATCH] Source list per profile

[Eyal Alaluf]

Hi,  Kornél.

The .jvm.cs are part of the Java build that we are now doing from svn using
make.
The issue is not limited to the .jvm files but also to Mono sources (e.g. in
System.Web) that are not part of the Java build. In System.Web we have about
30 Mono files that we don't compile in the Java build (because we don't
support yet on the fly compilation of .aspx files and CodeDom).
So in our case we have more files that belong to specific profiles or
combinations of profiles.
Personally, the issue here is the number of profiles and their complexity.
The more profiles are used the more useful the proposed change is. If
everyone believes that there are not going to be more profiles then the Java
profile then there is less incentive to change anything - the current
solution of ifdefs is still usable.

Eyal.

-----Original Message-----
From: mono-devel-list-bounces at lists.ximian.com
[mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Kornél Pál
Sent: Tuesday, August 16, 2005 1:08 PM
To: Yaacov Akiba Slama; Zoltan Varga
Cc: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] [PATCH] Source list per profile

I think the current soltion is elegant.

Are the .jvm directories used to build the java version using Mono build
system or are they here only as a reference?

If .jvm directories are not used there are only 23 files that are enclosed
in #if NET_2_0 || TARGET_JVM. These files are for 2.0 and java. But if .jvm
is used to build the java version there are much more java specific file.

Kornél

----- Original Message -----
From: "Yaacov Akiba Slama" <yaslama at mainsoft.com>
To: "Zoltan Varga" <vargaz at gmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Monday, August 15, 2005 11:52 AM
Subject: Re: [Mono-dev] [PATCH] Source list per profile


> Zoltan Varga wrote:
>
>>                                                  Hi,
>>
>>   The current solution might not be elegant, but it is simple, and it
>>works just fine.
>>
>>
> Yes. But because of the java profile, a large part of source files need
> to be enclosed by #ifdef.
> The solution Ynon proposed is still quite simple as you can see in the
> files Ynon sent.
>
> What do others think ?
>
> --yas
>
>>So I would vote for keeping it.
>>
>>                         Zoltan
>>
>>On 8/11/05, Ynon Koralek <ynonk at mainsoft.com> wrote:
>>
>>
>>>
>>>
>>>
>>>Hello,
>>>
>>>
>>>
>>>When building the libraries, each profile requires different source files
>>>especially with the "java" profile.
>>>
>>>That problem is solved today (for net_2_0) using #ifdef <PROFILE_NAME>
>>>enclosing the whole content of files but this solution is not IMHO very
>>>elegant.
>>>
>>>
>>>
>>>The solution we suggest is to use an .xml file which defines which source
>>>files need to be compiled for each profile.
>>>
>>>A new enclosed tool called gensourcelist creates a source file list from
>>>this xml file specific for the profile currently built.
>>>
>>>
>>>
>>>The included patch includes this tool, and the needed modifications of
>>>the
>>>Makefiles in order to build it and use it.
>>>
>>>We included also the xml file needed to replace System.Data.dll.sources
>>>
>>>
>>>
>>>Please comment on the whole mechanism and let us know what you think
>>>about
>>>it.
>>>
>>>
>>>
>>>Ynon
>>>_______________________________________________
>>>Mono-devel-list mailing list
>>>Mono-devel-list at lists.ximian.com
>>>http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>
>>>
>>>
>>>
>>>
>>>
>>_______________________________________________
>>Mono-devel-list mailing list
>>Mono-devel-list at lists.ximian.com
>>http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list