[Mono-devel-list] [PATCH] Check for assembly attributes

[Carlos Alberto Cortez]

Hey Marek,

Comments below:



> >
> >I changed it to CheckAttributeValidity, but I'm  not very sure about
> >it. Do you have any better idea?
> >  
> >
> What about 'CheckInternalsVisibleAttribute' ?
> 

Good. (Note that my idea was to have here some other attributes checks,
but, since we have only one, we can keep call it this way).

> >
> >The other things were applied. I attached two test cases. Do you think
> >we could need more tests?
> >  
> >
> They look fine.
> 
> BTW: Could not we use AssemblyName class from corlib to avoid this 
> parsing code ?
> 

Well, yes. That's exactly what I tought. But, we don't have a Parse ()
method that takes the assembly name (long format) and retrieves an
AssemblyName. At least, I didn't found it ;-)

Carlos.