[Mono-devel-list] [PATCH] Check for assembly attributes

[Carlos Alberto Cortez]

Hey Marek,

On 8/4/05, Marek Safar <marek.safar at seznam.cz> wrote:


> 
> +                               string [] args = a.GetString ().Trim ().Split (new char [] {','});
> 
> a.GetString () can return null.
> 

I don't think so. When the emtpy string is passed, it shows no errors.
When you don't pass any argument, it will complain about the
parameter. Or I'm missing something?

> +                       CheckAttributeValid (a);
> 
> Could you rename the method to be more explicit ?
> 

I changed it to CheckAttributeValidity, but I'm  not very sure about
it. Do you have any better idea?


The other things were applied. I attached two test cases. Do you think
we could need more tests?

Carlos.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: internals.patch
Type: text/x-patch
Size: 3367 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050804/595159e9/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcs0647.cs
Type: text/x-csharp
Size: 570 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050804/595159e9/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcs0647-2.cs
Type: text/x-csharp
Size: 508 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050804/595159e9/attachment-0002.bin