[Mono-devel-list] Re: Review of system.data

[Konstantin Triger]

Hello Uma,

I'm CCing mono-devel-list to this email, so anyone who wants to review 
the code can find it at 
svn://mono.myrealbox.com/source/branches/Mainsoft.System.Data/mcs/class/System.Data

1. There are 2 efforts made in the code: design improvements related to 
indices and bug fixes. Attached a brief design document of the indices 
redesign (questions are welcome). Regarding the bug fixes, I will create 
a relevant changelog.
2. The testsuite we have sent is nunit compatible. To run it, one need 
to enter the System.Data/Test/System.Data.Tests.Mainsoft directory and 
issue "make" command. After this, the following command should be issued 
(from the System.Data root):
MONO_PATH="../../class/lib/default;;$MONO_PATH" mono  --debug 
../../class/lib/default/nunit-console.exe   
/output:TestResult-Mainsoft.log 
/exclude:NotWorking,ValueAdd,CAS,InetAccess 
/xml:TestResult-Mainsoft.xml  
../../class/lib/default/System.Data.Tests.Mainsoft.dll

Currently there are 36 failures in the HEAD branch and 7 failures in the 
Mainsoft branch.
 From the other side there are 4 regressions running the standard mono 
testsuite in the Mainsoft branch.

I'm analysing all this now and will provide resolution/explanation for 
each one of the above.

3. Will send later today.

Regards,
Konstantin Triger



S Umadevi wrote:

>Hi 
>  We see that you have checked in the code in SVN under a different
>branch. You had agreed to send us the following (around 2 weeks back)so
>that the code can be reviewed effectively.
>1. Design document explaining the changes and why the changes are
>done.
>2. Testcases that are failing and what are the testcases that pass with
>the new code. The testcases that you have sent us are the complete set
>and as I had mentioned in my previous mails, the testcases that are new
>in your set needs to be identified to us.(since many  are already
>existing in nunit style)
>3. Since we have implemented the indices using arrays there would be
>some amount of performance degradation. In your mail, you had agreed to
>share the performance data/tests with us.. Please can you send them..
>
>We have been spending lot of time trying to review/understand the new
>code, since we will have to take it forward from here for the .net 2.0
>features, the above would be very useful..
>
>Also there have been code fixes after you had branched out, we would
>need to merge them too..along with merging the testcases to nunit style
>testing
>
>
>Thanks & Regards
>Uma
>
>
>
>
>  
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: indices.txt
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050427/ac6779fd/attachment.txt