[Mono-devel-list] [Fwd: [Mono-patches] r42885 - trunk/mcs/mcs]

[Raja R Harinath]

Hi,

Atsushi Eno <atsushi at ximian.com> writes:

> I think r42885 broke cs0208 tests in mcs/errors (verified that
> r42884 does not break them and r42885 does).
[snip]
> 2005-04-12  Miguel de Icaza  <miguel at novell.com>
>
> 	* typemanager.cs (IsUnmanagedType): Arrays are allowed.
[snip]
> Modified: trunk/mcs/mcs/typemanager.cs
> ===================================================================
> --- trunk/mcs/mcs/typemanager.cs	2005-04-12 23:26:24 UTC (rev 42884)
> +++ trunk/mcs/mcs/typemanager.cs	2005-04-13 01:38:44 UTC (rev 42885)
> @@ -1530,8 +1530,8 @@
>   		if (t.IsPointer)
>   			return true;
>
> -		if (!IsValueType (t))
> -			return false;
> +		if (t.IsArray)
> +			return IsUnmanagedType (t.GetElementType ());
>
>   		if (t is TypeBuilder){
>   			TypeContainer tc = LookupTypeContainer (t);

Yep.  I've restored the !IsValueType.  It turns out that this patch was
also the reason for the f-spot regression Miguel mailed me about.

- Hari