[Mono-devel-list] Re: Patch: 100% working mono under FreeBSD (small nit)
flashdict at gmail.com
Mon Apr 11 08:55:32 EDT 2005
Thanks Zoltan, we freebsd folks look forward to its inclusion.
Regarding $PREVIEW I guess it's enabled by default in svn and will be
disabled in the release?
Also, regarding the two nits I hurriedly sent, there's a Good
Explanation (tm) for those. As I was finalizing the patch, I noticed
that I had #ifdef'd only __FreeBSD__ for the sigaltstack changes in
exceptions-x86.c, where I could have checked for both FreeBSD and
NetBSD. I started to change it, then decided to double check. After
a visit to the NetBSD source CVS archive, I found that NetBSD _does_
define gregs, so the change was not needed. NetBSD sigaltstack
should build out of the box now with the SA_STACK change to
configure.in, and the command line option to configure.
Still, I should have done that one, last test build. I know.
On Apr 11, 2005 2:43 PM, Zoltan Varga <vargaz at gmail.com> wrote:
> This looks ok to me, except this part:
> AC_ARG_WITH(preview, [ --with-preview=yes,no If you want to
> install the 2.0 FX preview],[
> - if test x$with_preview = xyes; then
> - PREVIEW=yes
> + if test x$with_preview = xno; then
> + PREVIEW=no
> On Apr 11, 2005 12:48 PM, Bill Middleton <flashdict at gmail.com> wrote:
> > And one more. Thats what I get for doing last-minute touchups.
> > 313c313
> > < +#if def(__FreeBSD__)
> > ---
> > > +#if defined(__FreeBSD__)
> > Thanks for your patience, Complete, working patch attached.
> > Bill
More information about the Mono-devel-list